Skip to content

fix(test,benchmark): cap data tests to rlp block limit#2

Merged
LouisTsai-Csie merged 1 commit intoLouisTsai-Csie:update-benchmark-workflowfrom
fselmo:fix/failing-osaka-block-test
Feb 2, 2026
Merged

fix(test,benchmark): cap data tests to rlp block limit#2
LouisTsai-Csie merged 1 commit intoLouisTsai-Csie:update-benchmark-workflowfrom
fselmo:fix/failing-osaka-block-test

Conversation

@fselmo
Copy link

@fselmo fselmo commented Jan 31, 2026

🗒️ Description

  • Consider RLP limit for max data test... this does cap the data gas at the RLP limit so takes the min between the benchmark gas value and the rlp limit... I think this is OK? But we'd have to consider the intent of the test. Not sure there's another way tbh?
  • Use vars instead of hard-coded values for fixtures

✅ Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx tox -e static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).

Cute Animal Picture

Screenshot 2026-01-30 at 17 09 31

Copy link
Owner

@LouisTsai-Csie LouisTsai-Csie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the help

@LouisTsai-Csie LouisTsai-Csie merged commit 94f681f into LouisTsai-Csie:update-benchmark-workflow Feb 2, 2026
6 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants